Remove string concatenation with + from all Dart files in tools directory.

tools/ddbg.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Simple interactive debugger shell that connects to the Dart VM's debugger
 // connection port.
 
 #import("dart:io");
 #import("dart:json");
 
@@ skipping 40 matching lines @@
   return completer.future;
 }
 
 
 void processCommand(String cmdLine) {
   seqNum++;
   var args = cmdLine.split(' ');
   if (args.length == 0) {
     return;
   }
-  var cmd = args[0];
-  if (cmd == "r") {
+  var command = args[0];

[Bob Nystrom, 2012/05/22 17:23:14]

Nice change. :)

[Bill Hesse, 2012/05/23 08:49:20]

Or I could have just removed the inner "var" declarations - the outer "cmd"
variable (now "command") is dead at that point, so it could be reused for the
inner value.  Oh well.

+  if (command == "r") {
     var cmd = { "id": seqNum, "command": "resume" };
     sendCmd(cmd).then((result) => handleGenericResponse(result));
-  } else if (cmd == "s") {
+  } else if (command == "s") {
     var cmd = { "id": seqNum, "command": "stepOver" };
     sendCmd(cmd).then((result) => handleGenericResponse(result));
-  } else if (cmd == "si") {
+  } else if (command == "si") {
     var cmd = { "id": seqNum, "command": "stepInto" };
     sendCmd(cmd).then((result) => handleGenericResponse(result));
-  } else if (cmd == "so") {
+  } else if (command == "so") {
     var cmd = { "id": seqNum, "command": "stepOut" };
     sendCmd(cmd).then((result) => handleGenericResponse(result));
-  } else if (cmd == "bt") {
+  } else if (command == "bt") {
     var cmd = { "id": seqNum, "command": "getStackTrace" };
     sendCmd(cmd).then((result) => handleStackTraceResponse(result));
-  } else if (cmd == "ll") {
+  } else if (command == "ll") {
     var cmd = { "id": seqNum, "command": "getLibraryURLs" };
     sendCmd(cmd).then((result) => handleGetLibraryResponse(result));
-  } else if (cmd == "sbp") {
+  } else if (command == "sbp") {
     if (args.length < 3) {
       return;
     }
     var cmd = { "id": seqNum,
                 "command": "setBreakpoint",
                 "params": { "url": args[1], "line": Math.parseInt(args[2]) }};
     sendCmd(cmd).then((result) => handleSetBpResponse(result));
-  } else if (cmd == "ls") {
+  } else if (command == "ls") {
     if (args.length < 2) {
       return;
     }
     var cmd = { "id": seqNum,
                  "command": "getScriptURLs",
                 "params": { "library": args[1] }};
     sendCmd(cmd).then((result) => handleGetScriptsResponse(result));
-  } else if (cmd == "q") {
+  } else if (command == "q") {
     quitShell();
-  } else if (cmd == "h") {
+  } else if (command == "h") {
     printHelp();
   } else {
-    print("command '$cmd' not understood, try h for help");
+    print("command '$command' not understood, try h for help");
   }
 }
 
 
 void handleGetLibraryResponse(response) {
   var result = response["result"];
   assert(result != null);
   var urls = result["urls"];
   assert(urls != null);
   assert(urls is List);
@@ skipping 135 matching lines @@
   };
   vmInStream.onError = (err) {
     print("Error in debug connection: $err");
     quitShell();
   };
   vmInStream.onClosed = () {
     print("VM debugger connection closed");
     quitShell();
   };
 }