Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher)

Die build.py, Die

First few steps in the new docs server.

This CL has the BranchUtility class and the SubversionFetcher class, along with unit tests for both.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139132

[cduvall, 2012-05-22 00:07:40]

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:18: def
GetChannelNameFromURL(self, url):
Can probably make this shorter, but works for now.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:30: if name == 'trunk':
omahaproxy.appspot.com has no branch number for trunk?

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:48: if entry['os'] !=
'cf':
Not sure what os: cf was, but assumed it was the default or something.

[cduvall, 2012-05-22 00:12:47]

Still TODO: mock memcache and fetch

[Aaron Boodman, 2012-05-22 00:20:34]

Yup, this is roughly the right direction. You should also add some unit tests,
though it will take some investigation to figure out how to integrate them with
our test system. I'm not sure if we have any python unit tests today.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/app.yaml (right):

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/app.yaml:8: script: clark.py
I think this file should be called echo_handler.py, you can reuse it to build
the echo server when we get to that part.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:18: def
GetChannelNameFromURL(self, url):
On 2012/05/22 00:07:40, cduvall wrote:
> Can probably make this shorter, but works for now.

It should only count if it's the first url component.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:30: if name == 'trunk':
On 2012/05/22 00:07:40, cduvall wrote:
> http://omahaproxy.appspot.com has no branch number for trunk?

There's no branch number for trunk because ... it's trunk :). Instead of
http://src.chromium.org/viewvc/chrome/branches/<branchnum>, you look in
http://src.chromium.org/viewvc/chrome/trunk/

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:31: return 'trunk'
In this case I think you should throw an exception. Caller should not call this
function with 'trunk'.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:32: result =
memcache.get(name)
We are going to be using memcache for all kinds of things, so you're going to
want to use the namespace feature.

In fact, maybe we should just cache the url response from omahaproxy. So your
memcache namespace would be 'urls', and we will put other URLs that we fetch in
there in the future.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:42: if
result.status_code != 200:
Yeah, exception makes sense.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:48: if entry['os'] !=
'cf':
On 2012/05/22 00:07:40, cduvall wrote:
> Not sure what os: cf was, but assumed it was the default or something.

It stands for 'chromeframe' - you can search what it is. It's a good idea to
skip this one for our purposes; it frequently has a different version.

https://chromiumcodereview.appspot.com/10387225/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/branch_utility.py:50: for version in
entry['versions']:
Can you look at what version each platform has and use the most popular one? :).
I'm not sure what else to do in the case they disagree, that should be pretty
rare though.

[cduvall, 2012-05-22 01:23:54]

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/app.yaml (right):

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/app.yaml:8: script: clark.py
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> I think this file should be called echo_handler.py, you can reuse it to build
> the echo server when we get to that part.

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:18: def
GetChannelNameFromURL(self, url):
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> On 2012/05/22 00:07:40, cduvall wrote:
> > Can probably make this shorter, but works for now.
> 
> It should only count if it's the first url component.

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:30: if name == 'trunk':
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> On 2012/05/22 00:07:40, cduvall wrote:
> > http://omahaproxy.appspot.com has no branch number for trunk?
> 
> There's no branch number for trunk because ... it's trunk :). Instead of
> http://src.chromium.org/viewvc/chrome/branches/%3Cbranchnum>, you look in
> http://src.chromium.org/viewvc/chrome/trunk/

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:31: return 'trunk'
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> In this case I think you should throw an exception. Caller should not call
this
> function with 'trunk'.

I think its cleaner to handle trunk in here, since the branch number from omaha
can be trunk too. I'm just going to return trunk and have the caller handle it.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:32: result =
memcache.get(name)
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> We are going to be using memcache for all kinds of things, so you're going to
> want to use the namespace feature.
> 
> In fact, maybe we should just cache the url response from omahaproxy. So your
> memcache namespace would be 'urls', and we will put other URLs that we fetch
in
> there in the future.

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:42: if
result.status_code != 200:
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> Yeah, exception makes sense.

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:48: if entry['os'] !=
'cf':
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> On 2012/05/22 00:07:40, cduvall wrote:
> > Not sure what os: cf was, but assumed it was the default or something.
> 
> It stands for 'chromeframe' - you can search what it is. It's a good idea to
> skip this one for our purposes; it frequently has a different version.

Done.

http://codereview.chromium.org/10387225/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/branch_utility.py:50: for version in
entry['versions']:
On 2012/05/22 00:20:34, Aaron Boodman wrote:
> Can you look at what version each platform has and use the most popular one?
:).
> I'm not sure what else to do in the case they disagree, that should be pretty
> rare though.

Done.

[cduvall, 2012-05-22 01:28:18]

Unit tests on the way!

[cduvall, 2012-05-22 02:57:13]

On 2012/05/22 01:28:18, cduvall wrote:
> Unit tests on the way!

So here's what I did for unit tests:

The unit test framework is the same that is used in the json_schema_compiler.
Since the unit tests will be run in this directory, the imports for the
appengine need to be resolved. I added the "google" directory which mirrors the
structure of the appengine. Then we can override methods for testing as we need
to.

[Aaron Boodman, 2012-05-22 22:45:02]

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/PRESUBMIT.py (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/PRESUBMIT.py:20: input_api, output_api,
'.', whitelist=WHITELIST)
Huh. Never seen this approach before, but... cool.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/app.yaml (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/app.yaml:1: application:
chromeextensiondocs
Call this chromeextensiondocs2

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:15: def __init__(self):
You could simplify this somewhat by passing the urlfetch module into the
BranchUtility constructor.

I have a feeling we are going to end up wanting to cache all external URLs that
we rely on, so we will create a wrapper for AppEngine's urlfetch that does
caching in memcache.

For now, you can just pass in the real urlfetch though. This will also make it
easy to unit test. Just pass in a fake urlfetch.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:24: def
GetChannelNameFromURL(self, url):
I guess it's really GetChannelNameFromPath(), right? We're not dealing with full
URLs here.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:25: if
url.startswith('dev'):
startswith('dev/') ... same for the other branches.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:25: if
url.startswith('dev'):
first_part = path.split('/')[0]
if first_part in ['trunk', 'dev', 'beta', 'stable']:
  return first_part
else:
  return 'stable'

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:38: return 'trunk'
Still seems weird to accept trunk as an argument, but ok!

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:40: result =
MemcacheGet(url, 'urls')
With my change above, you wouldn't need this memcache stuff ... the urlfetch you
pass in would do it.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:49: if entry['os'] ==
'cf':
On second thought, let's be more robust and have a whitelist of platforms we
care about: linux, mac, win, and cros.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/fetch.py (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/fetch.py:15:
url="http://omahaproxy.appspot.com/json",
I don't think this or the stuff in google/appengine is necessary.

We should use dependency injection. Wherever we need to fetch urls, we take a
url_fetch as an argument to the caller's cosntructor. During test, we supply a
fake url fetcher, and in real life we use the one from app engine.

Later in our work, we can wrap the url_fetch module from app engine with a
version that consults memcache before the web.

[cduvall, 2012-05-24 00:15:40]

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/app.yaml (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/app.yaml:1: application:
chromeextensiondocs
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> Call this chromeextensiondocs2

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:15: def __init__(self):
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> You could simplify this somewhat by passing the urlfetch module into the
> BranchUtility constructor.
> 
> I have a feeling we are going to end up wanting to cache all external URLs
that
> we rely on, so we will create a wrapper for AppEngine's urlfetch that does
> caching in memcache.
> 
> For now, you can just pass in the real urlfetch though. This will also make it
> easy to unit test. Just pass in a fake urlfetch.

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:24: def
GetChannelNameFromURL(self, url):
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> I guess it's really GetChannelNameFromPath(), right? We're not dealing with
full
> URLs here.

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:25: if
url.startswith('dev'):
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> first_part = path.split('/')[0]
> if first_part in ['trunk', 'dev', 'beta', 'stable']:
>   return first_part
> else:
>   return 'stable'

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:38: return 'trunk'
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> Still seems weird to accept trunk as an argument, but ok!

I don't really like accepting trunk paths as an argument either, but some
channels have trunk as their branch. So the caller would have to have the trunk
vs. branch number logic twice (once before the call to filter out trunk paths,
and once after to filter them out again).

This way, they can pass any path into GetBranchNumber, and then do the trunk vs.
branch number logic after.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:40: result =
MemcacheGet(url, 'urls')
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> With my change above, you wouldn't need this memcache stuff ... the urlfetch
you
> pass in would do it.

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:49: if entry['os'] ==
'cf':
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> On second thought, let's be more robust and have a whitelist of platforms we
> care about: linux, mac, win, and cros.

Done.

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/fetch.py (right):

http://codereview.chromium.org/10387225/diff/10001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/fetch.py:15:
url="http://omahaproxy.appspot.com/json",
On 2012/05/22 22:45:02, Aaron Boodman wrote:
> I don't think this or the stuff in google/appengine is necessary.
> 
> We should use dependency injection. Wherever we need to fetch urls, we take a
> url_fetch as an argument to the caller's cosntructor. During test, we supply a
> fake url fetcher, and in real life we use the one from app engine.
> 
> Later in our work, we can wrap the url_fetch module from app engine with a
> version that consults memcache before the web.

Much better, good idea.

[cduvall, 2012-05-24 03:06:00]

Added a resource fetcher. Haven't checked it over too much though.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/echo_handler.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/echo_handler.py:42: content = 'File not
found.'
We can catch bad urls even from src.chromium.org. I don't think we're going to
need to use svn.chromium.org.

[Aaron Boodman, 2012-05-24 06:10:23]

LGTM - please fix these issues and commit when done... you don't need to wait
for another review from me.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:13: self.url =
'http://omahaproxy.appspot.com/json'
Nit: omaha_proxy_url ?

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:27: """Returns an empty
string if the branch number cannot be found.
Add a commment: This can throw in case of network errors, so that we don't
forget to handle that later.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:47: sorted_list = [x for
x in branch_numbers.iteritems()]
cute

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:52: if len(sorted_list)
> 0:
I think you should throw earlier if you get zero results. It's basically the
same thing as the request failing.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/echo_handler.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/echo_handler.py:42: content = 'File not
found.'
On 2012/05/24 03:06:00, cduvall wrote:
> We can catch bad urls even from http://src.chromium.org. I don't think we're
going to
> need to use http://svn.chromium.org.

Ah, it was directories I was thinking of. We can't tell the difference between a
real file in svn and, say: http://src.chromium.org/viewvc/chrome/trunk/

I guess it's a pretty minor thing, but it would be better to be correct. We can
come back to it.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/memcache.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/memcache.py:1: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
I think you can just use the appengine memcache directly for now. In the future,
if we need tests to override this behavior, we can dependency inject a module
that has the same API as app engine's memcache module.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/resource_fetcher.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/resource_fetcher.py:5: import logging
not used

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/test_urlfetch.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/test_urlfetch.py:13: 
Prefix ReadFile and MockResponse with _ to make clear that they are not intended
to be called.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/test_urlfetch.py:14: class
MockResponse(object):
Move this up above fetch()? (I'm surprised it compiles like this...)

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/urlfetch.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/urlfetch.py:8: from memcache import
MemcacheAdd, MemcacheGet
memcache will need to be dependency injected at some point. Not a big deal now.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/urlfetch.py:10: class
FetchException(Exception):
Prefix with _.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/urlfetch.py:17: result = MemcacheGet(url,
'urls')
Is there a way in python to get introspect a module name? That would be the
obvious thing to use as the namespace.

[cduvall, 2012-05-25 20:02:22]

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/branch_utility.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:13: self.url =
'http://omahaproxy.appspot.com/json'
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Nit: omaha_proxy_url ?

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:27: """Returns an empty
string if the branch number cannot be found.
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Add a commment: This can throw in case of network errors, so that we don't
> forget to handle that later.

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/branch_utility.py:52: if len(sorted_list)
> 0:
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> I think you should throw earlier if you get zero results. It's basically the
> same thing as the request failing.

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/resource_fetcher.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/resource_fetcher.py:5: import logging
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> not used

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/test_urlfetch.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/test_urlfetch.py:13: 
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Prefix ReadFile and MockResponse with _ to make clear that they are not
intended
> to be called.

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/test_urlfetch.py:14: class
MockResponse(object):
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Move this up above fetch()? (I'm surprised it compiles like this...)

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/urlfetch.py (right):

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/urlfetch.py:10: class
FetchException(Exception):
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Prefix with _.

Done.

http://codereview.chromium.org/10387225/diff/12014/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/urlfetch.py:17: result = MemcacheGet(url,
'urls')
On 2012/05/24 06:10:23, Aaron Boodman wrote:
> Is there a way in python to get introspect a module name? That would be the
> obvious thing to use as the namespace.

Done.

[commit-bot: I haz the power, 2012-05-25 20:24:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cduvall@chromium.org/10387225/14004

[commit-bot: I haz the power, 2012-05-25 22:20:21]

Change committed as 139132