chrome/common/extensions/docs/server2/test_urlfetch.py - Issue 10387225: Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/test_urlfetch.py

Issue 10387225: Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Resource fetcher Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/resource_fetcher.py ('K') | « chrome/common/extensions/docs/server2/test_data/subversion_fetcher/trunk/test.json ('k') | chrome/common/extensions/docs/server2/urlfetch.py » ('j') | chrome/common/extensions/docs/server2/urlfetch.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 def ReadFile(filename):

	6 with open(filename, 'r') as f:

	7 return f.read()

	8

	9 def fetch(url):

	10 result = MockResponse()

	11 result.content = ReadFile('test_data/' + url)

	12 return result

	13
	Aaron Boodman 2012/05/24 06:10:23 Prefix ReadFile and MockResponse with _ to make cl Prefix ReadFile and MockResponse with _ to make clear that they are not intended to be called. cduvall 2012/05/25 20:02:23 Done. Show quoted text On 2012/05/24 06:10:23, Aaron Boodman wrote: > Prefix ReadFile and MockResponse with _ to make clear that they are not intended > to be called. Done.
	14 class MockResponse(object):
	Aaron Boodman 2012/05/24 06:10:23 Move this up above fetch()? (I'm surprised it comp Move this up above fetch()? (I'm surprised it compiles like this...) cduvall 2012/05/25 20:02:23 Done. Show quoted text On 2012/05/24 06:10:23, Aaron Boodman wrote: > Move this up above fetch()? (I'm surprised it compiles like this...) Done.
	15 def __init__(self):

	16 self.content = ''

OLD	NEW