chrome/common/extensions/docs/server2/fetch.py - Issue 10387225: Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/fetch.py

Issue 10387225: Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Unit tests Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/branch_utility.py ('K') | « chrome/common/extensions/docs/server2/echo_handler.py ('k') | chrome/common/extensions/docs/server2/google/__init__.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from google.appengine.api import urlfetch

	6

	7 class FetchException(Exception):

	8 """Thrown when status code is not 200.

	9 """

	10 def __init__(self, url):

	11 Exception.__init__(self, 'Fetch exception from ' + url)

	12

	13 def Fetch(url):

	14 result = urlfetch.fetch(

	15 url="http://omahaproxy.appspot.com/json",
	Aaron Boodman 2012/05/22 22:45:02 I don't think this or the stuff in google/appengin I don't think this or the stuff in google/appengine is necessary. We should use dependency injection. Wherever we need to fetch urls, we take a url_fetch as an argument to the caller's cosntructor. During test, we supply a fake url fetcher, and in real life we use the one from app engine. Later in our work, we can wrap the url_fetch module from app engine with a version that consults memcache before the web. cduvall 2012/05/24 00:15:40 Much better, good idea. Show quoted text On 2012/05/22 22:45:02, Aaron Boodman wrote: > I don't think this or the stuff in google/appengine is necessary. > > We should use dependency injection. Wherever we need to fetch urls, we take a > url_fetch as an argument to the caller's cosntructor. During test, we supply a > fake url fetcher, and in real life we use the one from app engine. > > Later in our work, we can wrap the url_fetch module from app engine with a > version that consults memcache before the web. Much better, good idea.
	16 method=urlfetch.GET)

	17

	18 if result.status_code != 200:

	19 raise FetchException(url)

	20 return result.content

OLD	NEW