Support optional arguments in SendRequestNatives::StartRequest

content/renderer/v8_value_converter_impl.h

Index: content/renderer/v8_value_converter_impl.h
diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h
index c43da46ab7489b42b0eac5369b47a107935a7fd1..d3f91d014e3b277184fc7631382a4c934cdf4a16 100644
--- a/content/renderer/v8_value_converter_impl.h
+++ b/content/renderer/v8_value_converter_impl.h
@@ -22,14 +22,14 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
 
   // Use the following setters to support additional types other than the
   // default ones.
-  bool allow_undefined() const { return allow_undefined_; }

[jochen (gone - plz use gerrit), 2012/05/15 16:58:56]

any reason you renamed the functions? The coding style does not mandate virtual
setters/getters to be named differently

[battre, 2012/05/16 07:42:33]

See the thread "[chromium-dev] virtual functions -> CamelCase".

[jochen (gone - plz use gerrit), 2012/05/16 08:29:09]

ok, but then I'd name it SetUndefinedAllowed/GetUndefinedAllowed etc..

see other interfaces in content/public,  web_contents.h has e.g.
SetClosedByUserGesture/GetClosedByUserGesture

[battre, 2012/05/16 08:50:32]

Done.

-  void set_allow_undefined(bool val) { allow_undefined_ = val; }
+  virtual bool AllowUndefined() const OVERRIDE;
+  virtual void SetAllowUndefined(bool val) OVERRIDE;
 
-  bool allow_date() const { return allow_date_; }
-  void set_allow_date(bool val) { allow_date_ = val; }
+  virtual bool AllowDate() const OVERRIDE;
+  virtual void SetAllowDate(bool val) OVERRIDE;
 
-  bool allow_regexp() const { return allow_regexp_; }
-  void set_allow_regexp(bool val) { allow_regexp_ = val; }
+  virtual bool AllowRegexp() const OVERRIDE;
+  virtual void SetAllowRegexp(bool val) OVERRIDE;
 
   // V8ValueConverter implementation.
   virtual v8::Handle<v8::Value> ToV8Value(