Support optional arguments in SendRequestNatives::StartRequest

content/renderer/v8_value_converter_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 #define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
 #include "content/public/renderer/v8_value_converter.h"
 
 namespace base {
 class BinaryValue;
 class DictionaryValue;
 class ListValue;
 class Value;
 }
 
 class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
  public:
   V8ValueConverterImpl();
 
   // Use the following setters to support additional types other than the
   // default ones.
-  bool allow_undefined() const { return allow_undefined_; }

[jochen (gone - plz use gerrit), 2012/05/15 16:58:56]

any reason you renamed the functions? The coding style does not mandate virtual
setters/getters to be named differently

[battre, 2012/05/16 07:42:33]

See the thread "[chromium-dev] virtual functions -> CamelCase".

[jochen (gone - plz use gerrit), 2012/05/16 08:29:09]

ok, but then I'd name it SetUndefinedAllowed/GetUndefinedAllowed etc..

see other interfaces in content/public,  web_contents.h has e.g.
SetClosedByUserGesture/GetClosedByUserGesture

[battre, 2012/05/16 08:50:32]

Done.

-  void set_allow_undefined(bool val) { allow_undefined_ = val; }
+  virtual bool AllowUndefined() const OVERRIDE;
+  virtual void SetAllowUndefined(bool val) OVERRIDE;
 
-  bool allow_date() const { return allow_date_; }
-  void set_allow_date(bool val) { allow_date_ = val; }
+  virtual bool AllowDate() const OVERRIDE;
+  virtual void SetAllowDate(bool val) OVERRIDE;
 
-  bool allow_regexp() const { return allow_regexp_; }
-  void set_allow_regexp(bool val) { allow_regexp_ = val; }
+  virtual bool AllowRegexp() const OVERRIDE;
+  virtual void SetAllowRegexp(bool val) OVERRIDE;
 
   // V8ValueConverter implementation.
   virtual v8::Handle<v8::Value> ToV8Value(
       const base::Value* value,
       v8::Handle<v8::Context> context) const OVERRIDE;
   virtual base::Value* FromV8Value(
       v8::Handle<v8::Value> value,
       v8::Handle<v8::Context> context) const OVERRIDE;
 
  private:
@@ skipping 17 matching lines @@
   bool allow_undefined_;
 
   // If true, we will convert Date JavaScript objects to doubles.
   bool allow_date_;
 
   // If true, we will convet RegExp JavaScript objects to string.
   bool allow_regexp_;
 };
 
 #endif  // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_