content/renderer/render_view_impl.cc - Issue 10387055: Support optional arguments in SendRequestNatives::StartRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 10387055: Support optional arguments in SendRequestNatives::StartRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 6a9d750b053b4fee6ff8529bf6b1de8eb3157d0f..325579c2f19634e3cfd0c5dbd6259c6a85c89196 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3636,8 +3636,8 @@ void RenderViewImpl::EvaluateScript(const string16& frame_xpath,

v8::Local<v8::Context> context = web_frame->mainWorldScriptContext();

v8::Context::Scope context_scope(context);

V8ValueConverterImpl converter;

- converter.set_allow_date(true);

- converter.set_allow_regexp(true);

+ converter.SetAllowDate(true);

+ converter.SetAllowRegexp(true);

list.Set(0, converter.FromV8Value(result, context));

} else {

list.Set(0, Value::CreateNullValue());