Decouple DevTools from socket implementation.

chrome/browser/debugger/remote_debugging_server.cc

Index: chrome/browser/debugger/remote_debugging_server.cc
diff --git a/chrome/browser/debugger/remote_debugging_server.cc b/chrome/browser/debugger/remote_debugging_server.cc
index 0094e7e38e10f5d9a66f3a20c36c84dd161cab5f..472df71a1fb83e473c1b4a11f7a5c93ffe818896 100644
--- a/chrome/browser/debugger/remote_debugging_server.cc
+++ b/chrome/browser/debugger/remote_debugging_server.cc
@@ -9,6 +9,7 @@
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/devtools_ui.h"
 #include "content/public/browser/devtools_http_handler.h"
+#include "net/base/tcp_listen_socket.h"
 
 RemoteDebuggingServer::RemoteDebuggingServer(Profile* profile,
                                              const std::string& ip,
@@ -19,12 +20,12 @@ RemoteDebuggingServer::RemoteDebuggingServer(Profile* profile,
 
   net::URLRequestContextGetter* request_context_getter =
       profile->GetRequestContext();
-  devtools_http_handler_ =
-      content::DevToolsHttpHandler::Start(ip,
-                                          port,
-                                          frontend_url,
-                                          request_context_getter,
-                                          new BrowserListTabContentsProvider());
+
+  devtools_http_handler_ = content::DevToolsHttpHandler::Start(
+      frontend_url,
+      new net::TCPListenSocketFactory factory(ip, port),

[pfeldman, 2012/05/14 11:12:00]

Remove " factory"

[Philippe, 2012/05/14 12:36:52]

Wow indeed. Evil copy and paste. I'm surprised that it built.

+      request_context_getter,
+      new BrowserListTabContentsProvider());
 }
 
 RemoteDebuggingServer::~RemoteDebuggingServer() {