Decouple DevTools from socket implementation.

chrome/browser/debugger/remote_debugging_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/debugger/remote_debugging_server.h"
 
 #include "chrome/browser/debugger/browser_list_tabcontents_provider.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/devtools_ui.h"
 #include "content/public/browser/devtools_http_handler.h"
+#include "net/base/tcp_listen_socket.h"
 
 RemoteDebuggingServer::RemoteDebuggingServer(Profile* profile,
                                              const std::string& ip,
                                              int port,
                                              const std::string& frontend_url) {
   // Initialize DevTools data source.
   DevToolsUI::RegisterDevToolsDataSource(profile);
 
   net::URLRequestContextGetter* request_context_getter =
       profile->GetRequestContext();
-  devtools_http_handler_ =
-      content::DevToolsHttpHandler::Start(ip,
-                                          port,
-                                          frontend_url,
-                                          request_context_getter,
-                                          new BrowserListTabContentsProvider());
+
+  devtools_http_handler_ = content::DevToolsHttpHandler::Start(
+      frontend_url,
+      new net::TCPListenSocketFactory factory(ip, port),

[pfeldman, 2012/05/14 11:12:00]

Remove " factory"

[Philippe, 2012/05/14 12:36:52]

Wow indeed. Evil copy and paste. I'm surprised that it built.

+      request_context_getter,
+      new BrowserListTabContentsProvider());
 }
 
 RemoteDebuggingServer::~RemoteDebuggingServer() {
   devtools_http_handler_->Stop();
 }