Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: content/browser/debugger/devtools_http_handler_impl.h

Issue 10386048: Decouple DevTools from socket implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_http_handler_impl.h
diff --git a/content/browser/debugger/devtools_http_handler_impl.h b/content/browser/debugger/devtools_http_handler_impl.h
index 9cf3e9b1dfec45d6028153158fe2d84ff0f5aaa1..a9f020c04cf0cbc8bb2b64997ae3b1f2e8d0cde3 100644
--- a/content/browser/debugger/devtools_http_handler_impl.h
+++ b/content/browser/debugger/devtools_http_handler_impl.h
@@ -20,6 +20,7 @@
#include "net/url_request/url_request.h"
namespace net {
+class StreamListenSocketFactory;
class URLRequestContextGetter;
}
@@ -41,9 +42,9 @@ class DevToolsHttpHandlerImpl
static bool SortPageListByTime(const PageInfo& info1, const PageInfo& info2);
- DevToolsHttpHandlerImpl(const std::string& ip,
- int port,
- const std::string& frontend_url,
+ // Takes ownership over |socket_factory|.
+ DevToolsHttpHandlerImpl(const std::string& frontend_url,
+ net::StreamListenSocketFactory* socket_factory,
net::URLRequestContextGetter* request_context_getter,
DevToolsHttpHandlerDelegate* delegate);
virtual ~DevToolsHttpHandlerImpl();
@@ -93,9 +94,8 @@ class DevToolsHttpHandlerImpl
void AcceptWebSocket(int connection_id,
const net::HttpServerRequestInfo& request);
- std::string ip_;
- int port_;
std::string overridden_frontend_url_;
+ scoped_ptr<net::StreamListenSocketFactory> socket_factory_;
scoped_refptr<net::HttpServer> server_;
typedef std::map<net::URLRequest*, int>
RequestToSocketMap;

Powered by Google App Engine
This is Rietveld 408576698