Issue 10383004: Trim message posted to rietveld to 10000.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383004: Trim message posted to rietveld to 10000. (Closed)

Created:
8 years, 7 months ago by M-A Ruel

Modified:
8 years, 7 months ago

Reviewers:
Peter Mayo, Peter Mayo (wrong one)

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Trim message posted to rietveld to 10000. Rietveld doesn't post the message when it is too large. R=petermayo@chromium.org BUG= TEST=Now the CQ should stop having weird case where it doesn't post a message on CQ failure. It was because the message was simply too long! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135326

Patch Set 1 #

Patch Set 2 : Now works great! #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	rietveld.py	View	1	2 chunks	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Mayo (wrong one)

lgtm https://chromiumcodereview.appspot.com/10383004/diff/3001/rietveld.py File rietveld.py (right): https://chromiumcodereview.appspot.com/10383004/diff/3001/rietveld.py#newcode224 rietveld.py:224: message = message[:max_message-len(tail)] + tail Thanks for catching ...

8 years, 7 months ago (2012-05-04 03:05:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10383004/3001

8 years, 7 months ago (2012-05-04 13:11:59 UTC) #4

Change committed as 135326

Expand Messages | Collapse Messages