rietveld.py - Issue 10383004: Trim message posted to rietveld to 10000.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 10383004: Trim message posted to rietveld to 10000. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Now works great! Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index 70c64441fc31a01820c6a59466a6bdb4286c0be6..835f24c2a8a35d11257c8b0282848b83f2e86f88 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -1,3 +1,4 @@

+# coding: utf-8

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -217,6 +218,10 @@ class Rietveld(object):

('xsrf_token', self.xsrf_token())])

def add_comment(self, issue, message):

+ max_message = 10000

+ tail = '…\n(message too large)'

+ if len(message) > max_message:

+ message = message[:max_message-len(tail)] + tail

Peter Mayo (wrong one) 2012/05/04 03:05:36 Thanks for catching the "max_message - " Why doesn

logging.info('issue %s; comment: %s' % (issue, message))

return self.post('/%s/publish' % issue, [

('xsrf_token', self.xsrf_token()),

« no previous file with comments | « no previous file | no next file » | no next file with comments »