Trim message posted to rietveld to 10000.

rietveld.py

+# coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
   - Nobody else than issue owner can upload a patch set
@@ skipping 199 matching lines @@
     return svn_props
 
   def update_description(self, issue, description):
     """Sets the description for an issue on Rietveld."""
     logging.info('new description for issue %s' % issue)
     self.post('/%s/description' % issue, [
         ('description', description),
         ('xsrf_token', self.xsrf_token())])
 
   def add_comment(self, issue, message):
+    max_message = 10000
+    tail = '…\n(message too large)'
+    if len(message) > max_message:
+      message = message[:max_message-len(tail)] + tail

[Peter Mayo (wrong one), 2012/05/04 03:05:36]

Thanks for catching the "max_message - "
Why doesn't lint complain about missing spaces around the -  ?

     logging.info('issue %s; comment: %s' % (issue, message))
     return self.post('/%s/publish' % issue, [
         ('xsrf_token', self.xsrf_token()),
         ('message', message),
         ('message_only', 'True'),
         ('send_mail', 'True'),
         ('no_redirect', 'True')])
 
   def set_flag(self, issue, patchset, flag, value):
     return self.post('/%s/edit_flags' % issue, [
@@ skipping 101 matching lines @@
           if not 'Name or service not known' in e.reason:
             # Usually internal GAE flakiness.
             raise
         # If reaching this line, loop again. Uses a small backoff.
         time.sleep(1+maxtries*2)
     finally:
       upload.ErrorExit = old_error_exit
 
   # DEPRECATED.
   Send = get