Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/public/browser/web_contents.h

Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index 98934b7bd23168b6d5f4133308dc18de860f4806..ee8198402e82e1c611f1b331e2783466b27c12cb 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -98,9 +98,15 @@ class WebContents : public PageNavigator {
   // these may change over time.
   virtual RenderProcessHost* GetRenderProcessHost() const = 0;
 
+  // Gets the pending RenderProcessHost for this tab.
+  virtual RenderProcessHost* GetPendingRenderProcessHost() const = 0;

[jam, 2012/05/11 22:06:43]

1) only stuff used by embedders of content should be in the public API
2) the concept of pending RVH is an internal implementation detail of
WebContentsImpl that we don't expose by design

happy to talk more about this on Monday, or you can ask brettw who wrote this

[Fady Samuel, 2012/05/11 22:08:01]

Yup, just got rid of it. This is not absolutely necessary, but I'll need to cast
from WebContents to WebContentsImpl elsewhere.

[jam, 2012/05/14 04:48:15]

what I meant by 2 is that the whole concept of pending RVHs shouldn't be exposed
outside of WebContents. a lot of work was done to hide this (i.e. see how
RenderViewHostManager isn't exposed now, except only for tests)

+
   // Gets the current RenderViewHost for this tab.
   virtual RenderViewHost* GetRenderViewHost() const = 0;
 
+  // Gets the pending RenderViewHost for this tab.
+  virtual RenderViewHost* GetPendingRenderViewHost() const = 0;
+
   // Returns the currently active RenderWidgetHostView. This may change over
   // time and can be NULL (during setup and teardown).
   virtual content::RenderWidgetHostView* GetRenderWidgetHostView() const = 0;