Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
@@ skipping 80 matching lines @@
   virtual void SetViewType(content::ViewType type) = 0;
   virtual content::ViewType GetViewType() const = 0;
 
   // Gets the URL that is currently being displayed, if there is one.
   virtual const GURL& GetURL() const = 0;
 
   // Return the currently active RenderProcessHost and RenderViewHost. Each of
   // these may change over time.
   virtual RenderProcessHost* GetRenderProcessHost() const = 0;
 
+  // Gets the pending RenderProcessHost for this tab.
+  virtual RenderProcessHost* GetPendingRenderProcessHost() const = 0;

[jam, 2012/05/11 22:06:43]

1) only stuff used by embedders of content should be in the public API
2) the concept of pending RVH is an internal implementation detail of
WebContentsImpl that we don't expose by design

happy to talk more about this on Monday, or you can ask brettw who wrote this

[Fady Samuel, 2012/05/11 22:08:01]

Yup, just got rid of it. This is not absolutely necessary, but I'll need to cast
from WebContents to WebContentsImpl elsewhere.

[jam, 2012/05/14 04:48:15]

what I meant by 2 is that the whole concept of pending RVHs shouldn't be exposed
outside of WebContents. a lot of work was done to hide this (i.e. see how
RenderViewHostManager isn't exposed now, except only for tests)

+
   // Gets the current RenderViewHost for this tab.
   virtual RenderViewHost* GetRenderViewHost() const = 0;
 
+  // Gets the pending RenderViewHost for this tab.
+  virtual RenderViewHost* GetPendingRenderViewHost() const = 0;
+
   // Returns the currently active RenderWidgetHostView. This may change over
   // time and can be NULL (during setup and teardown).
   virtual content::RenderWidgetHostView* GetRenderWidgetHostView() const = 0;
 
   // The WebContentsView will never change and is guaranteed non-NULL.
   virtual WebContentsView* GetView() const = 0;
 
   // Create a WebUI page for the given url. In most cases, this doesn't need to
   // be called by embedders since content will create its own WebUI objects as
   // necessary. However if the embedder wants to create its own WebUI object and
@@ skipping 258 matching lines @@
   // Focuses the location bar.
   virtual void SetFocusToLocationBar(bool select_all) = 0;
 
   // Does this have an opener associated with it?
   virtual bool HasOpener() const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_