Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 4b1271c8c51c47040690623a1d79d906b9eb2f7e..8ca6d89f8e40f2e566608b99cf686e92a38853bc 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -28,6 +28,7 @@
 #include "ipc/ipc_platform_file.h"
 #include "media/base/channel_layout.h"
 #include "media/base/media_log_event.h"
+#include "ppapi/c/pp_instance.h"

[Charlie Reis, 2012/05/11 17:41:03]

I don't see where you're using this.

[Fady Samuel, 2012/05/11 22:03:34]

Done.

 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCompositionUnderline.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
@@ -650,9 +651,14 @@ IPC_STRUCT_BEGIN(ViewMsg_New_Params)
   // The properties of the screen associated with the view.
   IPC_STRUCT_MEMBER(WebKit::WebScreenInfo, screen_info)
 
-  // Indicates whether this newly created RenderView will be hosted by another
-  // RenderView.
-  IPC_STRUCT_MEMBER(bool, guest)
+  // The process id of the RenderProcessHost of the embedder of this view if it

[Charlie Reis, 2012/05/11 17:41:03]

nit: id -> ID

[Fady Samuel, 2012/05/11 22:03:34]

Done.

+  // has one.
+  IPC_STRUCT_MEMBER(int32, embedder_process_id)
+
+  // The routing ID of the embedder of this view if it has one.
+  // The process ID + routing ID uniquely identify the RenderViewHost

[Charlie Reis, 2012/05/11 17:41:03]

Please be specific about embedder_process_id and embedder_routing_id, since
"process ID + routing ID" refer to the current RVH, not the embedder.

[Fady Samuel, 2012/05/11 22:03:34]

Done.

+  // of the embedder.
+  IPC_STRUCT_MEMBER(int32, embedder_routing_id)
 
   // The accessibility mode of the renderer.
   IPC_STRUCT_MEMBER(AccessibilityMode, accessibility_mode)