Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 10263011: chromeos: Add support for dimming the screen. (Closed)

Created:
8 years, 7 months ago by Daniel Erat
Modified:
8 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos: Add support for dimming the screen. This makes Chrome listen for messages from the power manager asking it to dim or undim the screen. We'll use this on desktop devices with external displays to dim the screen just before blanking it when the user is idle. BUG=125176 TEST=added, also did manual testing with powerd changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134638

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -5 lines) Patch
M ash/ash.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +3 lines, -0 lines 0 comments Download
A ash/wm/screen_dimmer.h View 1 chunk +67 lines, -0 lines 0 comments Download
A ash/wm/screen_dimmer.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
A ash/wm/screen_dimmer_unittest.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/power/screen_dimming_observer.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/power/screen_dimming_observer.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 3 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
8 years, 7 months ago (2012-04-30 21:02:10 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 7 months ago (2012-04-30 21:36:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10263011/2001
8 years, 7 months ago (2012-04-30 21:57:09 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 23:42:09 UTC) #4
Change committed as 134638

Powered by Google App Engine
This is Rietveld 408576698