Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4864)

Unified Diff: chrome/browser/notifications/notification_ui_manager_impl.cc

Issue 10260021: Disable kDesktopNotificationPosition for ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nicer diff Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_ui_manager_impl.cc
diff --git a/chrome/browser/notifications/notification_ui_manager_impl.cc b/chrome/browser/notifications/notification_ui_manager_impl.cc
index dfe12fae6fd9bdfd6aca3270913df780f02edcd3..3fd11f0dcbc37e04a516526a90367a1aa425f781 100644
--- a/chrome/browser/notifications/notification_ui_manager_impl.cc
+++ b/chrome/browser/notifications/notification_ui_manager_impl.cc
@@ -52,7 +52,12 @@ NotificationUIManagerImpl::NotificationUIManagerImpl(PrefService* local_state)
registrar_.Add(this, content::NOTIFICATION_APP_TERMINATING,
content::NotificationService::AllSources());
position_pref_.Init(prefs::kDesktopNotificationPosition, local_state, this);
-#if defined(OS_MACOSX)
+#if defined(OS_CHROMEOS)
+ // Option menu for changing desktop notification position on ChromeOS is
+ // disabled. Force preference to default.
+ local_state->SetInteger(prefs::kDesktopNotificationPosition,
+ BalloonCollection::DEFAULT_POSITION);
sky 2012/05/08 17:49:05 Should this be in notification_prefs_manager.cc ?
+#elif defined(OS_MACOSX)
stevenjb 2012/05/08 16:57:44 nit: These should be two separate #if clauses, sin
InitFullScreenMonitor();
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698