Disable kDesktopNotificationPosition for ChromeOS

chrome/browser/notifications/notification_ui_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_ui_manager_impl.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 34 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(QueuedNotification);
 };
 
 NotificationUIManagerImpl::NotificationUIManagerImpl(PrefService* local_state)
     : balloon_collection_(NULL),
       is_user_active_(true) {
   registrar_.Add(this, content::NOTIFICATION_APP_TERMINATING,
                  content::NotificationService::AllSources());
   position_pref_.Init(prefs::kDesktopNotificationPosition, local_state, this);
-#if defined(OS_MACOSX)
+#if defined(OS_CHROMEOS)
+  // Option menu for changing desktop notification position on ChromeOS is
+  // disabled. Force preference to default.
+  local_state->SetInteger(prefs::kDesktopNotificationPosition,
+                          BalloonCollection::DEFAULT_POSITION);

[sky, 2012/05/08 17:49:05]

Should this be in notification_prefs_manager.cc  ?

+#elif defined(OS_MACOSX)

[stevenjb, 2012/05/08 16:57:44]

nit: These should be two separate #if clauses, since they are not related.

   InitFullScreenMonitor();
 #endif
 }
 
 NotificationUIManagerImpl::~NotificationUIManagerImpl() {
   STLDeleteElements(&show_queue_);
 #if defined(OS_MACOSX)
   StopFullScreenMonitor();
 #endif
 }
@@ skipping 170 matching lines @@
   } else if (type == chrome::NOTIFICATION_PREF_CHANGED) {
     std::string* name = content::Details<std::string>(details).ptr();
     if (*name == prefs::kDesktopNotificationPosition)
       balloon_collection_->SetPositionPreference(
           static_cast<BalloonCollection::PositionPreference>(
               position_pref_.GetValue()));
   } else {
     NOTREACHED();
   }
 }