Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 10260021: Disable kDesktopNotificationPosition for ChromeOS (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 7 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews
Visibility:
Public.

Description

It used to be possible to change the position of the notification bubble on ChromeOS. Now that the wrench menu for doing so is disabled it is no longer possible to change the balloon position. Force the pref to be the default position such that users are not stuck with the notification bubble in a weird place. Bug=None Test=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136043

Patch Set 1 #

Patch Set 2 : Changes as requested #

Patch Set 3 : Nicer diff #

Total comments: 2

Patch Set 4 : Change as requested #

Patch Set 5 : Nicer diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/notifications/notification_prefs_manager.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
pkotwicz
8 years, 7 months ago (2012-04-30 21:45:46 UTC) #1
pkotwicz
8 years, 7 months ago (2012-05-01 17:24:38 UTC) #2
Elliot Glaysher
I don't think I'm qualified to review this.
8 years, 7 months ago (2012-05-01 17:38:57 UTC) #3
sky
I don't know this code either. Is there someone else you can get to review?
8 years, 7 months ago (2012-05-01 17:55:48 UTC) #4
pkotwicz
8 years, 7 months ago (2012-05-02 22:55:32 UTC) #5
stevenjb
Is there an issue related to this? I'm not sure that I follow step 1), ...
8 years, 7 months ago (2012-05-02 23:07:49 UTC) #6
pkotwicz
I saw that the wrench menu has been removed from notifications. I still get the ...
8 years, 7 months ago (2012-05-03 01:03:50 UTC) #7
pkotwicz
The balloon is on the top right for me because it has been saved in ...
8 years, 7 months ago (2012-05-03 01:04:18 UTC) #8
stevenjb
On 2012/05/03 01:04:18, pkotwicz wrote: > The balloon is on the top right for me ...
8 years, 7 months ago (2012-05-03 18:02:26 UTC) #9
pkotwicz
Change as requested.
8 years, 7 months ago (2012-05-05 02:54:47 UTC) #10
stevenjb
lgtm http://codereview.chromium.org/10260021/diff/13001/chrome/browser/notifications/notification_ui_manager_impl.cc File chrome/browser/notifications/notification_ui_manager_impl.cc (right): http://codereview.chromium.org/10260021/diff/13001/chrome/browser/notifications/notification_ui_manager_impl.cc#newcode60 chrome/browser/notifications/notification_ui_manager_impl.cc:60: #elif defined(OS_MACOSX) nit: These should be two separate ...
8 years, 7 months ago (2012-05-08 16:57:44 UTC) #11
pkotwicz
Sky for rubberstamp
8 years, 7 months ago (2012-05-08 17:41:33 UTC) #12
sky
http://codereview.chromium.org/10260021/diff/13001/chrome/browser/notifications/notification_ui_manager_impl.cc File chrome/browser/notifications/notification_ui_manager_impl.cc (right): http://codereview.chromium.org/10260021/diff/13001/chrome/browser/notifications/notification_ui_manager_impl.cc#newcode59 chrome/browser/notifications/notification_ui_manager_impl.cc:59: BalloonCollection::DEFAULT_POSITION); Should this be in notification_prefs_manager.cc ?
8 years, 7 months ago (2012-05-08 17:49:05 UTC) #13
pkotwicz
Change as requested
8 years, 7 months ago (2012-05-09 05:39:43 UTC) #14
sky
LGTM
8 years, 7 months ago (2012-05-09 14:26:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10260021/13002
8 years, 7 months ago (2012-05-09 15:06:14 UTC) #16
commit-bot: I haz the power
8 years, 7 months ago (2012-05-09 16:23:32 UTC) #17
Change committed as 136043

Powered by Google App Engine
This is Rietveld 408576698