Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/resources/options2/browser_options.js

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes according to code reviews Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.js
diff --git a/chrome/browser/resources/options2/browser_options.js b/chrome/browser/resources/options2/browser_options.js
index 96b856e7466017931d7bd1fa6575046858e0dbde..acbad3f341c9b34a88a9649e99abd4c8196bb13c 100644
--- a/chrome/browser/resources/options2/browser_options.js
+++ b/chrome/browser/resources/options2/browser_options.js
@@ -1041,6 +1041,18 @@ cr.define('options', function() {
},
/**
+ * Set the visibility of the password generation checkbox.
+ * @private
+ */
+ setPasswordGenerationSettingVisibility_: function(visible) {
+ if (visible) {
+ $('passwordGenerationCheckbox').style.display = 'block';
+ } else {
+ $('passwordGenerationCheckbox').style.display = 'none';
+ }
Ilya Sherman 2012/05/04 06:04:50 nit: No need for curly braces for single-line stmt
zysxqn 2012/05/04 18:52:54 Done.
+ },
+
+ /**
* Set the font size selected item.
* @private
*/
@@ -1370,6 +1382,7 @@ cr.define('options', function() {
'setInstantFieldTrialStatus',
'setMetricsReportingCheckboxState',
'setMetricsReportingSettingVisibility',
+ 'setPasswordGenerationSettingVisibility',
'setProfilesInfo',
'setScreenMagnifierCheckboxState',
'setSpokenFeedbackCheckboxState',

Powered by Google App Engine
This is Rietveld 408576698