chrome/common/autofill_messages.h - Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/autofill_messages.h

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes according to code reviews Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options2/browser_options.js ('K') | « chrome/browser/ui/webui/options2/browser_options_handler2.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/autofill_messages.h

diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h

index 8c008d0cba4cbe457bbd71c826627031dff0127e..53efc4a96ec3b2c04a366abe1d9b769b97467a94 100644

--- a/chrome/common/autofill_messages.h

+++ b/chrome/common/autofill_messages.h

@@ -118,7 +118,7 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_SetNodeText,

IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,

string16 /* generated_password */)

-// Tells the renderer if password generation should be enabled.

+// Tells the renderer if password generation preference is enabled.

Ilya Sherman 2012/05/04 06:04:50 nit: "preference" is too narrow, since it also dep

zysxqn 2012/05/04 18:52:54 Done.

IPC_MESSAGE_ROUTED1(AutofillMsg_PasswordGenerationEnabled,

bool /* is_enabled */)