chrome/browser/resources/options2/browser_options.html - Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/browser_options.html

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes according to code reviews Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_manager_unittest.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/resources/options2/browser_options.js » ('j') | chrome/browser/resources/options2/browser_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options2/browser_options.html

diff --git a/chrome/browser/resources/options2/browser_options.html b/chrome/browser/resources/options2/browser_options.html

index ad3cede1b95beb872b534828bfefc10228273830..2346190dc077d99292df821952ee21009ab27d4b 100644

--- a/chrome/browser/resources/options2/browser_options.html

+++ b/chrome/browser/resources/options2/browser_options.html

@@ -311,6 +311,13 @@

i18n-content="managePasswords"

pref="profile.password_manager_enabled"></button>

</div>

+ <div class="checkbox" id="passwordGenerationCheckbox">

Ilya Sherman 2012/05/04 06:04:50 nit: Ids should use hyphenated-name-casing

zysxqn 2012/05/04 18:52:54 Done.

+ <label>

+ <input id="passwordGenerationEnabled" pref="password_generation.enabled"

Ilya Sherman 2012/05/04 06:04:50 nit: Ditto, though in this case perhaps we can rem

zysxqn 2012/05/04 18:52:54 Done.

+ metric="Options_PasswordGenerationCheckbox" type="checkbox">

+ <span i18n-content="passwordGenerationEnabledDescription"></span>

+ </label>

+ </div>

</div>