Make downloads.download() respect host permissions

chrome/common/extensions/extension.cc

Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 899720410f8a9ce238839b1ae0e51ba74107c200..238352d5dc936a89c96edcbb05277ba7c20f8618 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -3231,6 +3231,17 @@ bool Extension::HasHostPermission(const GURL& url) const {
       location() != Extension::COMPONENT) {
     return false;
   }
+  if (url.SchemeIs(chrome::kExtensionScheme) &&

[Aaron Boodman, 2012/05/09 05:32:38]

I think you can replace this entire new hunk with:

if (url.GetOrigin() == extension_url_.GetOrigin())
  return true;

That said, it might make more sense to add this to the call site inside the
download extension API. I'm nervous about implications of adding this on all
other users of host permissions.

[Aaron Boodman, 2012/05/09 18:28:44]

If this check were not here, are there multiple places where it would be needed
in the download API, or only one?

[benjhayden, 2012/05/09 21:36:42]

download() is the only function that will accept and access a URL. Even if there
were another function, I could factor it out into a downloads-specific base
class or function.

The question is whether the origin check belongs in Extension. I'm happy to go
with your judgement and put it in DownloadsDownloadFunction instead.

+      url.host() == id()) {
+    return true;
+  }
+  if (url.inner_url() != NULL &&
+      url.inner_url()->is_valid() &&
+      url.SchemeIsFileSystem() &&
+      url.inner_url()->SchemeIs(chrome::kExtensionScheme) &&
+      url.inner_url()->host() == id()) {
+    return true;
+  }
 
   base::AutoLock auto_lock(runtime_data_lock_);
   return runtime_data_.GetActivePermissions()->