chrome/browser/download/download_extension_api.cc - Issue 10213002: Make downloads.download() respect host permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_extension_api.cc

Issue 10213002: Make downloads.download() respect host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_extension_api.cc

diff --git a/chrome/browser/download/download_extension_api.cc b/chrome/browser/download/download_extension_api.cc

index cdf0193ff2ef33882e4c8323ea762f597ede8def..725db13ff4572a6bd13d813b6d7e00910f030008 100644

--- a/chrome/browser/download/download_extension_api.cc

+++ b/chrome/browser/download/download_extension_api.cc

@@ -380,6 +380,12 @@ bool DownloadsDownloadFunction::ParseArgs() {

return false;

}

+ if (!iodata_->url.SchemeIs("data") &&

+ !GetExtension()->HasHostPermission(iodata_->url)) {

+ error_ = download_extension_errors::kInvalidURLError;

+ return false;

+ }

if (options->HasKey(kFilenameKey)) {

EXTENSION_FUNCTION_VALIDATE(options->GetString(

kFilenameKey, &iodata_->filename));