Make downloads.download() respect host permissions

chrome/common/extensions/extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 3213 matching lines @@
   return runtime_data_.GetActivePermissions()->effective_hosts();
 }
 
 bool Extension::HasHostPermission(const GURL& url) const {
   if (url.SchemeIs(chrome::kChromeUIScheme) &&
       url.host() != chrome::kChromeUIFaviconHost &&
       url.host() != chrome::kChromeUIThumbnailHost &&
       location() != Extension::COMPONENT) {
     return false;
   }
+  if (url.SchemeIs(chrome::kExtensionScheme) &&

[Aaron Boodman, 2012/05/09 05:32:38]

I think you can replace this entire new hunk with:

if (url.GetOrigin() == extension_url_.GetOrigin())
  return true;

That said, it might make more sense to add this to the call site inside the
download extension API. I'm nervous about implications of adding this on all
other users of host permissions.

[Aaron Boodman, 2012/05/09 18:28:44]

If this check were not here, are there multiple places where it would be needed
in the download API, or only one?

[benjhayden, 2012/05/09 21:36:42]

download() is the only function that will accept and access a URL. Even if there
were another function, I could factor it out into a downloads-specific base
class or function.

The question is whether the origin check belongs in Extension. I'm happy to go
with your judgement and put it in DownloadsDownloadFunction instead.

+      url.host() == id()) {
+    return true;
+  }
+  if (url.inner_url() != NULL &&
+      url.inner_url()->is_valid() &&
+      url.SchemeIsFileSystem() &&
+      url.inner_url()->SchemeIs(chrome::kExtensionScheme) &&
+      url.inner_url()->host() == id()) {
+    return true;
+  }
 
   base::AutoLock auto_lock(runtime_data_lock_);
   return runtime_data_.GetActivePermissions()->
       HasExplicitAccessToOrigin(url);
 }
 
 bool Extension::HasEffectiveAccessToAllHosts() const {
   base::AutoLock auto_lock(runtime_data_lock_);
   return runtime_data_.GetActivePermissions()->HasEffectiveAccessToAllHosts();
 }
@@ skipping 300 matching lines @@
     already_disabled(false),
     extension(extension) {}
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const ExtensionPermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}