Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10168021: Pass through readInfo.resultCode. (Closed)

Created:
8 years, 8 months ago by miket_OOO
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Pass through readInfo.resultCode. BUG=124498 TEST=added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133501

Patch Set 1 #

Patch Set 2 : Improve test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/extensions/api/socket/socket_api.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.socket.idl View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/socket/api/background.js View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
miket_OOO
8 years, 8 months ago (2012-04-20 23:06:30 UTC) #1
jeremya
lgtm
8 years, 8 months ago (2012-04-20 23:08:39 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-20 23:16:24 UTC) #3
miket_OOO
Aaron, can you fill in as a reviewer today? Two of our three full committers ...
8 years, 8 months ago (2012-04-23 16:27:04 UTC) #4
miket_OOO
Never mind, Aaron; Antony's back.
8 years, 8 months ago (2012-04-23 18:06:20 UTC) #5
asargent_no_longer_on_chrome
LGTM
8 years, 8 months ago (2012-04-23 18:28:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/10168021/1004
8 years, 8 months ago (2012-04-23 18:31:36 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:49:12 UTC) #8
Change committed as 133501

Powered by Google App Engine
This is Rietveld 408576698