Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5010)

Unified Diff: chrome/test/data/extensions/api_test/socket/api/background.js

Issue 10168021: Pass through readInfo.resultCode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve test. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/experimental.socket.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/socket/api/background.js
diff --git a/chrome/test/data/extensions/api_test/socket/api/background.js b/chrome/test/data/extensions/api_test/socket/api/background.js
index 576fd2e0112326304312dc0f21def97160fa4a09..7eb987458796f93fc0f9d8840c87c58bac1a5526 100644
--- a/chrome/test/data/extensions/api_test/socket/api/background.js
+++ b/chrome/test/data/extensions/api_test/socket/api/background.js
@@ -76,6 +76,10 @@ var testSocketCreation = function() {
};
function onDataRead(readInfo) {
+ if (readInfo.resultCode > 0 || readInfo.data.length > 0) {
+ chrome.test.assertEq(readInfo.resultCode, readInfo.data.length);
+ }
+
// TODO(miket): this isn't correct for multiple calls of onDataRead.
arrayBuffer2String(arrayOfLongsToArrayBuffer(readInfo.data), function(s) {
dataAsString = s; // save this for error reporting
@@ -115,7 +119,7 @@ function onEvent(socketEvent) {
if (socketEvent.type == "connectComplete") {
onConnectComplete(socketEvent.resultCode);
} else if (socketEvent.type == "dataRead") {
- onDataRead({data: socketEvent.data});
+ onDataRead({resultCode: socketEvent.resultCode, data: socketEvent.data});
} else if (socketEvent.type == "writeComplete") {
onWriteComplete(socketEvent.resultCode);
} else {
« no previous file with comments | « chrome/common/extensions/api/experimental.socket.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698