Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: chrome/common/extensions/api/experimental.socket.idl

Issue 10168021: Pass through readInfo.resultCode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve test. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/experimental.socket.idl
diff --git a/chrome/common/extensions/api/experimental.socket.idl b/chrome/common/extensions/api/experimental.socket.idl
index b919b811005056ffac392e944d2d99d651a765c5..7fdef7f64bbcfec4a75088f0a4a252b9bffd9ad8 100644
--- a/chrome/common/extensions/api/experimental.socket.idl
+++ b/chrome/common/extensions/api/experimental.socket.idl
@@ -14,8 +14,9 @@
// that blocked.
DOMString type;
- // The result code, if the event type is writeComplete. The result code
- // description matches that of <code>writeInfo.bytesWritten</code>.
+ // The result code, if the event type is dataRead or writeComplete. The
+ // result code description matches the resultCode field in the immediate
+ // callback for the call that led to this event.
long? resultCode;
// The data read, if the event type is dataRead.
@@ -52,6 +53,9 @@
callback ConnectCallback = void (long result);
dictionary ReadInfo {
+ // The resultCode returned from the underlying read() call.
+ long resultCode;
+
// The data received. Warning: will probably become a blob or other
// appropriate binary-friendly type.
// TODO(miket): [instanceOf=ArrayBuffer]object data;
« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/test/data/extensions/api_test/socket/api/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698