Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10124016: Addition of GL_CHROMIUM_copy_texture extension. (Closed)

Created:
8 years, 8 months ago by Jeff Timanus
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Re-submission of http://codereview.chromium.org/9968113 This version corrects the problem that caussed the revert of the above issue. The shaders used by the extension were specifying a precision, which is not supported on desktop GL. The shaders now conditionallyspecify the precision. Introduction of CHROMIUM_copy_texture extension that respects pixel-store semantics, and allows copying of BGRA textures. OpenGL ES does not natively allow for copying textures with a BGRA format. The EXT_texture_format_BGRA8888 extension does not specify support for glCopyTexImage calls on these textures. This extension provides a routine to perform texture copies to/from BGRA-backed textures that also respects the following CHROMIUM pixel storage modifiers: UNPACK_FLIP_Y_CHROMIUM UNPACK_PREMULTIPLY_ALPHA_CHROMIUM This extension will be useful for the following purposes: - Copying accelerated Canvas2D contents to WebGL textures without a software readback. (And potentially the same for video-webgl texture copies.) - Copying Canvas2D contents to the compositor backing store. BUG=101051 TEST=none

Patch Set 1 #

Patch Set 2 : Removing dangling error checking code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+985 lines, -42 lines) Patch
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt View 1 chunk +66 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 11 chunks +13 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +48 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +19 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 1 chunk +41 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 1 chunk +248 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 22 chunks +168 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 2 chunks +11 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 15 chunks +56 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 5 chunks +25 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 12 chunks +206 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeff Timanus
Hi Gregg & Al, Could one of you please give this revision a quick look. ...
8 years, 8 months ago (2012-04-19 20:41:07 UTC) #1
apatrick_chromium
lgtm
8 years, 8 months ago (2012-04-19 20:45:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/twiz@chromium.org/10124016/12002
8 years, 8 months ago (2012-04-20 15:18:33 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-20 17:06:35 UTC) #4
Change committed as 133213

Powered by Google App Engine
This is Rietveld 408576698