chrome/browser/ui/views/infobars/extension_infobar.cc - Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: peter review -> revert one case Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/infobars/extension_infobar.cc

diff --git a/chrome/browser/ui/views/infobars/extension_infobar.cc b/chrome/browser/ui/views/infobars/extension_infobar.cc

index 4694c6240912c659a65cae4e40ab4a2b79f0e436..e151698c3ab808935ca1c4536919a92e04828738 100644

--- a/chrome/browser/ui/views/infobars/extension_infobar.cc

+++ b/chrome/browser/ui/views/infobars/extension_infobar.cc

@@ -148,7 +148,7 @@ void ExtensionInfoBar::OnMenuButtonClicked(views::View* source,

scoped_refptr<ExtensionContextMenuModel> options_menu_contents =

new ExtensionContextMenuModel(extension, browser_, NULL);

- DCHECK_EQ(source, menu_);

+ DCHECK_EQ(menu_, source);

RunMenuAt(options_menu_contents.get(), menu_, views::MenuItemView::TOPLEFT);

}