chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: peter review -> revert one case Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index 97afb7f4f96ec4f9d98b95bb3e6808bbe4cf3584..31b676f45a9a1fb89d9f4cfa08d4cba5596fbf95 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -174,8 +174,8 @@ void OneClickSigninBubbleView::LinkClicked(views::Link* source,

advanced_callback_.Run();

}

-void OneClickSigninBubbleView::ButtonPressed(

- views::Button* sender, const views::Event& event) {

- DCHECK_EQ(sender, close_button_);

+void OneClickSigninBubbleView::ButtonPressed(views::Button* sender,

+ const views::Event& event) {

+ DCHECK_EQ(close_button_, sender);

StartFade(false);

}