chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: peter review -> revert one case Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index ae28757ad4675e69039a5c3c3659ca326bcfbffc..e1aa0a79178593ad70b5cf8fcfcb40de585d8e22 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -298,7 +298,7 @@ void BookmarkBubbleView::HandleButtonPressed(views::Button* sender) {

content::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));

ShowEditor();

} else {

- DCHECK_EQ(sender, close_button_);

+ DCHECK_EQ(close_button_, sender);

StartFade(false);

}

« no previous file with comments | « no previous file | chrome/browser/ui/views/infobars/extension_infobar.cc » ('j') | no next file with comments »