Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3996)

Unified Diff: chrome/browser/safe_browsing/malware_details_history.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/malware_details_history.cc
diff --git a/chrome/browser/safe_browsing/malware_details_history.cc b/chrome/browser/safe_browsing/malware_details_history.cc
index 3947f36fd8332e3a72d27bdb55ffcd8be973500f..1cf11ef3d94696953c0b80ef832393e4f27e2cad 100644
--- a/chrome/browser/safe_browsing/malware_details_history.cc
+++ b/chrome/browser/safe_browsing/malware_details_history.cc
@@ -30,9 +30,6 @@ MalwareDetailsRedirectsCollector::MalwareDetailsRedirectsCollector(
}
}
-MalwareDetailsRedirectsCollector::~MalwareDetailsRedirectsCollector() {
-}
-
void MalwareDetailsRedirectsCollector::StartHistoryCollection(
const std::vector<GURL>& urls,
const base::Closure& callback) {
@@ -51,6 +48,27 @@ void MalwareDetailsRedirectsCollector::StartHistoryCollection(
this, urls));
}
+bool MalwareDetailsRedirectsCollector::HasStarted() const {
+ return has_started_;
+}
+
+const std::vector<safe_browsing::RedirectChain>&
+MalwareDetailsRedirectsCollector::GetCollectedUrls() const {
+ return redirects_urls_;
+}
+
+void MalwareDetailsRedirectsCollector::Observe(
+ int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_DESTROYED);
+ DVLOG(1) << "Profile gone.";
+ profile_ = NULL;
+}
+
+MalwareDetailsRedirectsCollector::~MalwareDetailsRedirectsCollector() {}
+
void MalwareDetailsRedirectsCollector::StartGetRedirects(
const std::vector<GURL>& urls) {
// History access from profile needs to happen in UI thread
@@ -109,27 +127,8 @@ void MalwareDetailsRedirectsCollector::OnGotQueryRedirectsTo(
GetRedirects(*urls_it_);
}
-bool MalwareDetailsRedirectsCollector::HasStarted() const {
- return has_started_;
-}
-
void MalwareDetailsRedirectsCollector::AllDone() {
DVLOG(1) << "AllDone";
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
callback_.Reset();
}
-
-const std::vector<safe_browsing::RedirectChain>&
-MalwareDetailsRedirectsCollector::GetCollectedUrls() const {
- return redirects_urls_;
-}
-
-void MalwareDetailsRedirectsCollector::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_DESTROYED);
- DVLOG(1) << "Profile gone.";
- profile_ = NULL;
-}
« no previous file with comments | « chrome/browser/safe_browsing/malware_details_history.h ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698