Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: chrome/browser/safe_browsing/malware_details_history.h

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/malware_details_history.h
diff --git a/chrome/browser/safe_browsing/malware_details_history.h b/chrome/browser/safe_browsing/malware_details_history.h
index b956aedaf764aa430bffa9528864b9d2142aae81..50efb772d2264827b062c93f6fc4dcbf848dd063 100644
--- a/chrome/browser/safe_browsing/malware_details_history.h
+++ b/chrome/browser/safe_browsing/malware_details_history.h
@@ -33,7 +33,6 @@ class MalwareDetailsRedirectsCollector
public content::NotificationObserver {
public:
explicit MalwareDetailsRedirectsCollector(Profile* profile);
- virtual ~MalwareDetailsRedirectsCollector();
// Collects urls' redirects chain information from the history service.
// We get access to history service via tab_contents in UI thread.
@@ -47,11 +46,29 @@ class MalwareDetailsRedirectsCollector
// Returns the redirect urls we get from history service
const std::vector<safe_browsing::RedirectChain>& GetCollectedUrls() const;
+ // content::NotificationObserver
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
private:
friend struct content::BrowserThread::DeleteOnThread<
content::BrowserThread::UI>;
friend class base::DeleteHelper<MalwareDetailsRedirectsCollector>;
+ virtual ~MalwareDetailsRedirectsCollector();
+
+ void StartGetRedirects(const std::vector<GURL>& urls);
+ void GetRedirects(const GURL& url);
+ void OnGotQueryRedirectsTo(HistoryService::Handle handle,
+ GURL url,
+ bool success,
+ history::RedirectList* redirect_list);
+
+ // Posts the callback method back to IO thread when redirects collecting
+ // is all done.
+ void AllDone();
+
Profile* profile_;
CancelableRequestConsumer request_consumer_;
@@ -71,21 +88,6 @@ class MalwareDetailsRedirectsCollector
content::NotificationRegistrar registrar_;
- void StartGetRedirects(const std::vector<GURL>& urls);
- void GetRedirects(const GURL& url);
- void OnGotQueryRedirectsTo(HistoryService::Handle handle,
- GURL url,
- bool success,
- history::RedirectList* redirect_list);
-
- // Posts the callback method back to IO thread when redirects collecting
- // is all done.
- void AllDone();
-
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
DISALLOW_COPY_AND_ASSIGN(MalwareDetailsRedirectsCollector);
};
« no previous file with comments | « chrome/browser/safe_browsing/malware_details_cache.cc ('k') | chrome/browser/safe_browsing/malware_details_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698