RefCounted types should not have public destructors, chrome/browser/ part 5

chrome/browser/safe_browsing/malware_details_history.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of the MalwareDetailsRedirectsCollector class.
 
 #include "chrome/browser/safe_browsing/malware_details_history.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 12 matching lines @@
     Profile* profile)
     : profile_(profile),
       has_started_(false) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (profile) {
     registrar_.Add(this, chrome::NOTIFICATION_PROFILE_DESTROYED,
                    content::Source<Profile>(profile));
   }
 }
 
-MalwareDetailsRedirectsCollector::~MalwareDetailsRedirectsCollector() {
-}
-
 void MalwareDetailsRedirectsCollector::StartHistoryCollection(
     const std::vector<GURL>& urls,
     const base::Closure& callback) {
   DVLOG(1) << "Num of urls to check in history service: " << urls.size();
   has_started_ = true;
   callback_ = callback;
 
   if (urls.size() == 0) {
     AllDone();
     return;
   }
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&MalwareDetailsRedirectsCollector::StartGetRedirects,
                  this, urls));
 }
 
+bool MalwareDetailsRedirectsCollector::HasStarted() const {
+  return has_started_;
+}
+
+const std::vector<safe_browsing::RedirectChain>&
+MalwareDetailsRedirectsCollector::GetCollectedUrls() const {
+  return redirects_urls_;
+}
+
+void MalwareDetailsRedirectsCollector::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_DESTROYED);
+  DVLOG(1) << "Profile gone.";
+  profile_ = NULL;
+}
+
+MalwareDetailsRedirectsCollector::~MalwareDetailsRedirectsCollector() {}
+
 void MalwareDetailsRedirectsCollector::StartGetRedirects(
         const std::vector<GURL>& urls) {
   // History access from profile needs to happen in UI thread
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   for (size_t i = 0; i < urls.size(); ++i) {
     urls_.push_back(urls[i]);
   }
   urls_it_ = urls_.begin();
   GetRedirects(*urls_it_);
 }
@@ skipping 38 matching lines @@
   ++urls_it_;
 
   if (urls_it_ == urls_.end()) {
     AllDone();
     return;
   }
 
   GetRedirects(*urls_it_);
 }
 
-bool MalwareDetailsRedirectsCollector::HasStarted() const {
-  return has_started_;
-}
-
 void MalwareDetailsRedirectsCollector::AllDone() {
   DVLOG(1) << "AllDone";
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
   callback_.Reset();
 }
-
-const std::vector<safe_browsing::RedirectChain>&
-MalwareDetailsRedirectsCollector::GetCollectedUrls() const {
-  return redirects_urls_;
-}
-
-void MalwareDetailsRedirectsCollector::Observe(
-    int type,
-    const content::NotificationSource& source,
-    const content::NotificationDetails& details) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_DESTROYED);
-  DVLOG(1) << "Profile gone.";
-  profile_ = NULL;
-}