Issue 10067034: RefCounted types should not have public destructors, printing/ and ui/

Issue 10067034: RefCounted types should not have public destructors, printing/ and ui/ (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi

Modified:
8 years, 7 months ago

Reviewers:
Lei Zhang, apatrick_chromium, piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, dhollowa+watch_chromium.org, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

RefCounted types should not have public destructors, printing/ and ui/ BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134859

Patch Set 2 : Implementation ordering #

Total comments: 2

Patch Set 3 : Fix #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -99 lines)			Patch
M	printing/backend/print_backend.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	printing/backend/print_backend_chromeos.cc	View	1	1 chunk	+11 lines, -13 lines	0 comments	Download
M	printing/backend/print_backend_cups.cc	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	printing/backend/print_backend_win.cc	View	1	1 chunk	+12 lines, -11 lines	0 comments	Download
M	ui/gfx/compositor/compositor.h	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_context_cgl.h	View	1	3 chunks	+9 lines, -7 lines	0 comments	Download
M	ui/gfx/gl/gl_context_cgl.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/gfx/gl/gl_context_osmesa.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	ui/gfx/gl/gl_context_osmesa.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/gfx/gl/gl_context_stub.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	ui/gfx/gl/gl_context_stub.cc	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	ui/gfx/gl/gl_surface.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface.cc	View	1	3 chunks	+9 lines, -12 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_cgl.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_cgl.cc	View	1	3 chunks	+7 lines, -9 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_osmesa.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	ui/gfx/gl/gl_surface_osmesa.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_stub.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/gfx/gl/gl_surface_stub.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

piman

http://codereview.chromium.org/10067034/diff/4001/ui/gfx/compositor/compositor.h File ui/gfx/compositor/compositor.h (right): http://codereview.chromium.org/10067034/diff/4001/ui/gfx/compositor/compositor.h#newcode108 ui/gfx/compositor/compositor.h:108: ~Texture(); needs to stay virtual+protected, the class is extended ...

8 years, 7 months ago (2012-04-30 17:08:05 UTC) #4

Ryan Sleevi

http://codereview.chromium.org/10067034/diff/4001/ui/gfx/compositor/compositor.h File ui/gfx/compositor/compositor.h (right): http://codereview.chromium.org/10067034/diff/4001/ui/gfx/compositor/compositor.h#newcode108 ui/gfx/compositor/compositor.h:108: ~Texture(); On 2012/04/30 17:08:05, piman wrote: > needs to ...

8 years, 7 months ago (2012-04-30 17:12:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10067034/9002

8 years, 7 months ago (2012-05-02 00:38:32 UTC) #8

Change committed as 134859

Expand Messages | Collapse Messages