RefCounted types should not have public destructors, printing/ and ui/

ui/gfx/compositor/compositor.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_COMPOSITOR_COMPOSITOR_H_
 #define UI_GFX_COMPOSITOR_COMPOSITOR_H_
 #pragma once
 
 #include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
@@ skipping 20 matching lines @@
 namespace ui {
 
 class Compositor;
 class CompositorObserver;
 class Layer;
 
 // This class abstracts the creation of the 3D context for the compositor. It is
 // a global object.
 class COMPOSITOR_EXPORT ContextFactory {
  public:
-  virtual ~ContextFactory() { }
+  virtual ~ContextFactory() {}
 
   // Gets the global instance.
   static ContextFactory* GetInstance();
 
   // Sets the global instance. Caller keeps ownership.
   // If this function isn't called (for tests), a "default" factory will be
   // created on the first call of GetInstance.
   static void SetInstance(ContextFactory* instance);
 
   // Creates a context for given compositor. The factory may keep per-compositor
@@ skipping 38 matching lines @@
   scoped_refptr<gfx::GLShareGroup> share_group_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultContextFactory);
 };
 
 // Texture provide an abstraction over the external texture that can be passed
 // to a layer.
 class COMPOSITOR_EXPORT Texture : public base::RefCounted<Texture> {
  public:
   Texture(bool flipped, const gfx::Size& size);
-  virtual ~Texture();
 
   unsigned int texture_id() const { return texture_id_; }
   void set_texture_id(unsigned int id) { texture_id_ = id; }
   bool flipped() const { return flipped_; }
   gfx::Size size() const { return size_; }
 
  private:
+  friend class base::RefCounted<Texture>;
+  ~Texture();

[piman, 2012/04/30 17:08:05]

needs to stay virtual+protected, the class is extended in
content/browser/renderer_host/image_transport_client.h

[Ryan Sleevi, 2012/04/30 17:12:59]

Done.

+
   unsigned int texture_id_;
   bool flipped_;
   gfx::Size size_;
 
   DISALLOW_COPY_AND_ASSIGN(Texture);
 };
 
 // An interface to allow the compositor to communicate with its owner.
 class COMPOSITOR_EXPORT CompositorDelegate {
  public:
@@ skipping 114 matching lines @@
   // This is set to true when the swap buffers has been posted and we're waiting
   // for completion.
   bool swap_posted_;
 
   friend class base::RefCounted<Compositor>;
 };
 
 }  // namespace ui
 
 #endif  // UI_GFX_COMPOSITOR_COMPOSITOR_H_