Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3696)

Unified Diff: chrome/browser/ui/webui/quota_internals_proxy.h

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/quota_internals_proxy.h
diff --git a/chrome/browser/ui/webui/quota_internals_proxy.h b/chrome/browser/ui/webui/quota_internals_proxy.h
index ebc613b5d391d7e9aeaad7650fa88102cff8a7fd..7857ed83df03d2a389d5325ec0f8079259b46236 100644
--- a/chrome/browser/ui/webui/quota_internals_proxy.h
+++ b/chrome/browser/ui/webui/quota_internals_proxy.h
@@ -13,7 +13,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
-#include "base/message_loop_helpers.h"
+#include "base/sequenced_task_runner_helpers.h"
#include "content/public/browser/browser_thread.h"
#include "webkit/quota/quota_manager.h"
#include "webkit/quota/quota_types.h"
@@ -35,14 +35,19 @@ class QuotaInternalsProxy
content::BrowserThread::DeleteOnIOThread> {
public:
explicit QuotaInternalsProxy(QuotaInternalsHandler* handler);
- ~QuotaInternalsProxy();
void RequestInfo(scoped_refptr<quota::QuotaManager> quota_manager);
private:
+ friend struct content::BrowserThread::DeleteOnThread<
+ content::BrowserThread::IO>;
+ friend class base::DeleteHelper<QuotaInternalsProxy>;
+
typedef quota::QuotaManager::QuotaTableEntries QuotaTableEntries;
typedef quota::QuotaManager::OriginInfoTableEntries OriginInfoTableEntries;
+ virtual ~QuotaInternalsProxy();
+
void ReportAvailableSpace(int64 available_space);
void ReportGlobalInfo(const GlobalStorageInfo& data);
void ReportPerHostInfo(const std::vector<PerHostStorageInfo>& hosts);

Powered by Google App Engine
This is Rietveld 408576698