RefCounted types should not have public destructors, chrome/browser/ui

chrome/browser/ui/cocoa/select_file_dialog_mac.mm

Index: chrome/browser/ui/cocoa/select_file_dialog_mac.mm
diff --git a/chrome/browser/ui/cocoa/select_file_dialog_mac.mm b/chrome/browser/ui/cocoa/select_file_dialog_mac.mm
index 37cbb83ceb4bdebe6e8b6da4a69c5a81ec54549c..6d05e7c84ba9fd1d2399f3e523be82f1759d397b 100644
--- a/chrome/browser/ui/cocoa/select_file_dialog_mac.mm
+++ b/chrome/browser/ui/cocoa/select_file_dialog_mac.mm
@@ -54,7 +54,6 @@ class SelectFileDialogImpl;
 class SelectFileDialogImpl : public SelectFileDialog {
  public:
   explicit SelectFileDialogImpl(Listener* listener);
-  virtual ~SelectFileDialogImpl();
 
   // BaseShellDialog implementation.
   virtual bool IsRunning(gfx::NativeWindow parent_window) const;
@@ -85,9 +84,11 @@ class SelectFileDialogImpl : public SelectFileDialog {
                               int file_type_index,
                               const FilePath::StringType& default_extension,
                               gfx::NativeWindow owning_window,
-                              void* params);
+                              void* params) OVERRIDE;

[Nico, 2012/04/13 17:09:11]

Huh, I thought avi had made the plugin check for mandatory OVERRIDEs in source
files as well?

[Ryan Sleevi, 2012/04/13 17:23:04]

No. That's why I split the plugin change into two parts - the first part adds
support for checking implementation files.

While OVERRIDE /works/ if annotated, the style checker doesn't enforce it. I
have a second patch for that - but it's an even larger changeset then this, so
I'm saving that for at least a few more weekends/evenings. This was just some
low hanging fruit.

 
  private:
+  virtual ~SelectFileDialogImpl();
+
   // Gets the accessory view for the save dialog.
   NSView* GetAccessoryView(const FileTypeInfo* file_types,
                            int file_type_index);