Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4495)

Unified Diff: chrome/browser/ui/webui/options2/options_ui2.cc

Issue 10067033: RefCounted types should not have public destructors, chrome/browser/ui (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/options_ui2.cc
diff --git a/chrome/browser/ui/webui/options2/options_ui2.cc b/chrome/browser/ui/webui/options2/options_ui2.cc
index a0adc59a37286169a8ac600891949ef6c22dfe37..c144e2077b5ae401b98e54a565e5a8452e672991 100644
--- a/chrome/browser/ui/webui/options2/options_ui2.cc
+++ b/chrome/browser/ui/webui/options2/options_ui2.cc
@@ -109,7 +109,6 @@ class OptionsUIHTMLSource : public ChromeURLDataManager::DataSource {
public:
// The constructor takes over ownership of |localized_strings|.
explicit OptionsUIHTMLSource(DictionaryValue* localized_strings);
- virtual ~OptionsUIHTMLSource();
// Called when the network layer has requested a resource underneath
// the path we registered.
@@ -119,6 +118,8 @@ class OptionsUIHTMLSource : public ChromeURLDataManager::DataSource {
virtual std::string GetMimeType(const std::string&) const;
private:
+ virtual ~OptionsUIHTMLSource();
+
// Localized strings collection.
scoped_ptr<DictionaryValue> localized_strings_;

Powered by Google App Engine
This is Rietveld 408576698