Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: net/spdy/spdy_session.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index f6b360dc69c866fb6dfe7b8b9b7dd7e2b8efa0c6..d70620b970666b831ea4d31b483642e5f312f07c 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -112,13 +112,17 @@ class NetLogSpdySessionParameter : public NetLog::EventParameters {
public:
NetLogSpdySessionParameter(const HostPortProxyPair& host_pair)
: host_pair_(host_pair) {}
+
virtual Value* ToValue() const {
DictionaryValue* dict = new DictionaryValue();
dict->Set("host", new StringValue(host_pair_.first.ToString()));
dict->Set("proxy", new StringValue(host_pair_.second.ToPacString()));
return dict;
}
+
private:
+ virtual ~NetLogSpdySessionParameter() {}
+
const HostPortProxyPair host_pair_;
DISALLOW_COPY_AND_ASSIGN(NetLogSpdySessionParameter);
};
@@ -142,7 +146,8 @@ class NetLogSpdySettingParameter : public NetLog::EventParameters {
}
private:
- ~NetLogSpdySettingParameter() {}
+ virtual ~NetLogSpdySettingParameter() {}
+
const SpdySettingsIds id_;
const SpdySettingsFlags flags_;
const uint32 value_;

Powered by Google App Engine
This is Rietveld 408576698