Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: net/spdy/spdy_stream.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream.cc
diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc
index 0fa6290161eddf94ea13135bd63d224205b9f988..bd5f911a2e69a3fe55be936d4bfd12fffe26c5e5 100644
--- a/net/spdy/spdy_stream.cc
+++ b/net/spdy/spdy_stream.cc
@@ -42,6 +42,7 @@ class NetLogSpdyStreamWindowUpdateParameter : public NetLog::EventParameters {
int32 delta,
int32 window_size)
: stream_id_(stream_id), delta_(delta), window_size_(window_size) {}
+
virtual Value* ToValue() const {
DictionaryValue* dict = new DictionaryValue();
dict->SetInteger("id", static_cast<int>(stream_id_));
@@ -49,7 +50,10 @@ class NetLogSpdyStreamWindowUpdateParameter : public NetLog::EventParameters {
dict->SetInteger("window_size", window_size_);
return dict;
}
+
private:
+ virtual ~NetLogSpdyStreamWindowUpdateParameter() {}
+
const SpdyStreamId stream_id_;
const int32 delta_;
const int32 window_size_;

Powered by Google App Engine
This is Rietveld 408576698