net/url_request/url_request_netlog_params.cc - Issue 10066045: RefCounted types should not have public destructors, net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_netlog_params.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_netlog_params.cc

diff --git a/net/url_request/url_request_netlog_params.cc b/net/url_request/url_request_netlog_params.cc

index 42076bcce17f1b6d1df2dc147ffc5afa30693714..6b3e398b7fca022a606e02ec7226f58b2c3e6022 100644

--- a/net/url_request/url_request_netlog_params.cc

+++ b/net/url_request/url_request_netlog_params.cc

@@ -19,6 +19,8 @@ URLRequestStartEventParameters::URLRequestStartEventParameters(

priority_(priority) {

}

+URLRequestStartEventParameters::~URLRequestStartEventParameters() {}

eroman 2012/04/13 18:59:34 match declaration order.

Value* URLRequestStartEventParameters::ToValue() const {

DictionaryValue* dict = new DictionaryValue();

dict->SetString("url", url_.possibly_invalid_spec());