Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: net/dns/dns_transaction.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/dns_transaction.cc
diff --git a/net/dns/dns_transaction.cc b/net/dns/dns_transaction.cc
index dd7b659e306d19cf8cd22bc0000ed419d15682b3..2073b7f4cb5216962a17257ea174a57cedc51a1b 100644
--- a/net/dns/dns_transaction.cc
+++ b/net/dns/dns_transaction.cc
@@ -64,6 +64,8 @@ class StartParameters : public NetLog::EventParameters {
}
private:
+ virtual ~StartParameters() {}
+
const std::string hostname_;
const uint16 qtype_;
};
@@ -82,6 +84,8 @@ class ResponseParameters : public NetLog::EventParameters {
}
private:
+ virtual ~ResponseParameters() {}
+
const int rcode_;
const int answer_count_;
const NetLog::Source source_;

Powered by Google App Engine
This is Rietveld 408576698