Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: net/disk_cache/net_log_parameters.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/net_log_parameters.cc
diff --git a/net/disk_cache/net_log_parameters.cc b/net/disk_cache/net_log_parameters.cc
index 76d79d7a28a577a068886aa921dcd84d88d4517e..17d1bb3d9cb5b8715366ed12c5903a28d861d296 100644
--- a/net/disk_cache/net_log_parameters.cc
+++ b/net/disk_cache/net_log_parameters.cc
@@ -16,6 +16,8 @@ EntryCreationParameters::EntryCreationParameters(
: key_(key), created_(created) {
}
+EntryCreationParameters::~EntryCreationParameters() {}
+
Value* EntryCreationParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
dict->SetString("key", key_);
@@ -28,6 +30,8 @@ ReadWriteDataParameters::ReadWriteDataParameters(
: index_(index), offset_(offset), buf_len_(buf_len), truncate_(truncate) {
}
+ReadWriteDataParameters::~ReadWriteDataParameters() {}
+
Value* ReadWriteDataParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
dict->SetInteger("index", index_);
@@ -38,12 +42,13 @@ Value* ReadWriteDataParameters::ToValue() const {
return dict;
}
-
// NetLog parameters logged when non-sparse reads and writes complete.
ReadWriteCompleteParameters::ReadWriteCompleteParameters(int bytes_copied)
: bytes_copied_(bytes_copied) {
}
+ReadWriteCompleteParameters::~ReadWriteCompleteParameters() {}
+
Value* ReadWriteCompleteParameters::ToValue() const {
DCHECK_NE(bytes_copied_, net::ERR_IO_PENDING);
DictionaryValue* dict = new DictionaryValue();
@@ -60,6 +65,8 @@ SparseOperationParameters::SparseOperationParameters(
: offset_(offset), buff_len_(buff_len) {
}
+SparseOperationParameters::~SparseOperationParameters() {}
+
Value* SparseOperationParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
// Values can only be created with at most 32-bit integers. Using a string
@@ -74,6 +81,8 @@ SparseReadWriteParameters::SparseReadWriteParameters(
: source_(source), child_len_(child_len) {
}
+SparseReadWriteParameters::~SparseReadWriteParameters() {}
+
Value* SparseReadWriteParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
dict->Set("source_dependency", source_.ToValue());
@@ -86,6 +95,8 @@ GetAvailableRangeResultParameters::GetAvailableRangeResultParameters(
: start_(start), result_(result) {
}
+GetAvailableRangeResultParameters::~GetAvailableRangeResultParameters() {}
+
Value* GetAvailableRangeResultParameters::ToValue() const {
DictionaryValue* dict = new DictionaryValue();
if (result_ > 0) {

Powered by Google App Engine
This is Rietveld 408576698