Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: net/disk_cache/net_log_parameters.h

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/net_log_parameters.h
diff --git a/net/disk_cache/net_log_parameters.h b/net/disk_cache/net_log_parameters.h
index d0b0c291baae0117f5b3eef82ddd68e972fa0725..7fdd72820a7139d79990de090bfeedbc44fa0680 100644
--- a/net/disk_cache/net_log_parameters.h
+++ b/net/disk_cache/net_log_parameters.h
@@ -22,6 +22,8 @@ class EntryCreationParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~EntryCreationParameters();
+
const std::string key_;
const bool created_;
@@ -36,6 +38,8 @@ class ReadWriteDataParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ReadWriteDataParameters();
+
const int index_;
const int offset_;
const int buf_len_;
@@ -54,6 +58,8 @@ class ReadWriteCompleteParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ReadWriteCompleteParameters();
+
const int bytes_copied_;
DISALLOW_COPY_AND_ASSIGN(ReadWriteCompleteParameters);
@@ -66,6 +72,8 @@ class SparseOperationParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~SparseOperationParameters();
+
const int64 offset_;
const int buff_len_;
};
@@ -78,6 +86,8 @@ class SparseReadWriteParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~SparseReadWriteParameters();
+
const net::NetLog::Source source_;
const int child_len_;
};
@@ -90,6 +100,8 @@ class GetAvailableRangeResultParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~GetAvailableRangeResultParameters();
+
const int64 start_;
const int result_;
};

Powered by Google App Engine
This is Rietveld 408576698