Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: net/cookies/cookie_monster.cc

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/cookie_monster.cc
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc
index 63eff033910f4b9da46873c41918e89809c7c98a..22c6879e9c53b08334ca047bbd6c7c17511aa559 100644
--- a/net/cookies/cookie_monster.cc
+++ b/net/cookies/cookie_monster.cc
@@ -591,6 +591,8 @@ class CookieMonster::SetCookieWithDetailsTask
virtual void Run() OVERRIDE;
private:
+ virtual ~SetCookieWithDetailsTask() {}
+
GURL url_;
std::string name_;
std::string value_;
@@ -626,6 +628,8 @@ class CookieMonster::GetAllCookiesTask
virtual void Run() OVERRIDE;
private:
+ virtual ~GetAllCookiesTask() {}
+
CookieMonster::GetCookieListCallback callback_;
DISALLOW_COPY_AND_ASSIGN(GetAllCookiesTask);
@@ -656,6 +660,8 @@ class CookieMonster::GetAllCookiesForURLWithOptionsTask
virtual void Run() OVERRIDE;
private:
+ virtual ~GetAllCookiesForURLWithOptionsTask() {}
+
GURL url_;
CookieOptions options_;
CookieMonster::GetCookieListCallback callback_;
@@ -683,6 +689,8 @@ class CookieMonster::DeleteAllTask : public CookieMonster::CookieMonsterTask {
virtual void Run() OVERRIDE;
private:
+ virtual ~DeleteAllTask() {}
+
CookieMonster::DeleteCallback callback_;
DISALLOW_COPY_AND_ASSIGN(DeleteAllTask);
@@ -713,6 +721,8 @@ class CookieMonster::DeleteAllCreatedBetweenTask
virtual void Run() OVERRIDE;
private:
+ virtual ~DeleteAllCreatedBetweenTask() {}
+
Time delete_begin_;
Time delete_end_;
CookieMonster::DeleteCallback callback_;
@@ -743,6 +753,8 @@ class CookieMonster::DeleteAllForHostTask
virtual void Run() OVERRIDE;
private:
+ virtual ~DeleteAllForHostTask() {}
+
GURL url_;
CookieMonster::DeleteCallback callback_;
@@ -772,6 +784,8 @@ class CookieMonster::DeleteCanonicalCookieTask
virtual void Run() OVERRIDE;
private:
+ virtual ~DeleteCanonicalCookieTask() {}
+
CookieMonster::CanonicalCookie cookie_;
CookieMonster::DeleteCookieCallback callback_;
@@ -804,6 +818,8 @@ class CookieMonster::SetCookieWithOptionsTask
virtual void Run() OVERRIDE;
private:
+ virtual ~SetCookieWithOptionsTask() {}
+
GURL url_;
std::string cookie_line_;
CookieOptions options_;
@@ -837,6 +853,8 @@ class CookieMonster::GetCookiesWithOptionsTask
virtual void Run() OVERRIDE;
private:
+ virtual ~GetCookiesWithOptionsTask() {}
+
GURL url_;
CookieOptions options_;
CookieMonster::GetCookiesCallback callback_;
@@ -869,6 +887,8 @@ class CookieMonster::GetCookiesWithInfoTask
virtual void Run() OVERRIDE;
private:
+ virtual ~GetCookiesWithInfoTask() {}
+
GURL url_;
CookieOptions options_;
CookieMonster::GetCookieInfoCallback callback_;
@@ -904,6 +924,8 @@ class CookieMonster::DeleteCookieTask
virtual void Run() OVERRIDE;
private:
+ virtual ~DeleteCookieTask() {}
+
GURL url_;
std::string cookie_name_;
base::Closure callback_;

Powered by Google App Engine
This is Rietveld 408576698