Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: net/cookies/cookie_monster.h

Issue 10066045: RefCounted types should not have public destructors, net/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index f6485665983e9acfd36927926d3c049c39dff346..4620a2b5353a97a028bef10f06c5d246d429fbd6 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -927,8 +927,6 @@ typedef base::RefCountedThreadSafe<CookieMonster::PersistentCookieStore>
class CookieMonster::PersistentCookieStore
: public RefcountedPersistentCookieStore {
public:
- virtual ~PersistentCookieStore() {}
-
typedef base::Callback<void(const std::vector<
CookieMonster::CanonicalCookie*>&)> LoadedCallback;
@@ -957,7 +955,10 @@ class CookieMonster::PersistentCookieStore
virtual void Flush(const base::Closure& callback) = 0;
protected:
+ friend class base::RefCountedThreadSafe<PersistentCookieStore>;
+
PersistentCookieStore() {}
+ virtual ~PersistentCookieStore() {}
private:
DISALLOW_COPY_AND_ASSIGN(PersistentCookieStore);

Powered by Google App Engine
This is Rietveld 408576698