Issue 10025004: Floating point based Point/Size/Rect and Insets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10025004: Floating point based Point/Size/Rect and Insets (Closed)

Created:
8 years, 8 months ago by oshima

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, pkotwicz

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Floating point based Point/Size/Rect and Insets This is copied from integer version, instead of using template, to minimize conflict with m19 branch, as using template requires updating forward declaration of these classes in many places. I put this behind gyp flag for now so that we can move forward without breaking non DIP build until we can get aura working with DIP. BUG=114664 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131405

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+713 lines, -0 lines)			Patch
M	build/common.gypi	View	1 2	5 chunks	+9 lines, -0 lines	0 comments	Download
A	ui/gfx/insets_f.h	View	1 2	1 chunk	+89 lines, -0 lines	0 comments	Download
A	ui/gfx/insets_f.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	ui/gfx/point_f.h	View	1 2	1 chunk	+93 lines, -0 lines	0 comments	Download
A	ui/gfx/point_f.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	ui/gfx/rect_f.h	View	1 2	1 chunk	+154 lines, -0 lines	0 comments	Download
A	ui/gfx/rect_f.cc	View		1 chunk	+204 lines, -0 lines	0 comments	Download
A	ui/gfx/size_f.h	View	1 2	1 chunk	+69 lines, -0 lines	0 comments	Download
A	ui/gfx/size_f.cc	View		1 chunk	+41 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10025004/7001

8 years, 8 months ago (2012-04-09 17:56:44 UTC) #4

Change committed as 131405

Expand Messages | Collapse Messages